session-stores/cookie: Convert private volatile properties to methods #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using native getters would work too, but only in some newer versions of Ember. Older versions will have `this` assigned to the wrong thing and are not able to access `this.get` due to that. Using a regular method should work fine though and since these properties are private we can change the signature without it having to be a breaking change.
locks
approved these changes
Jul 5, 2019
josemarluedke
approved these changes
Jul 10, 2019
This was referenced Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using native getters would work too, but only in some newer versions of Ember. Older versions will have
thisassigned to the wrong thing and are not able to accessthis.getdue to that. Using a regular method should work fine though and since these properties are private we can change the signature without it having to be a breaking change.Resolves the other part of #1799